Robert Widhopf-Fenk <[EMAIL PROTECTED]> writes:

> This was the first time I created a bundle and  from the
> docs I was not really sure how to use bundle-revisions ...

No harm ;-).

Next step: it's better to use attachments, with a MIME type
"text/something", like text/plain or text/x-patch, this way, you make
sure you don't modify the bundle accidentally, and the beginning and
end of it are more clear.

(in particular, here, you've added a space in the beginning of the
first line, I'm not sure the bundle parser is robust to that).

Side note: when you include several revisions, "bzr bundle" will give
the human-readable diff on top, and uuencodeed representation of the
intermediate revisions in between. This makes review easy, but keeps
all the advantages of a "bzr merge" (in particular, subsequent merges
will work without conflicts).

> === modified file lisp/dvc-build.el // last-changed:[EMAIL PROTECTED]
> ... -0a0b62f6f2c88ef0
> --- lisp/dvc-build.el
> +++ lisp/dvc-build.el
> @@ -34,6 +34,8 @@
>  (push srcdir load-path)
>  (push loaddir load-path)
>  
> +;(setq debug-on-error t)
> +
>  ;; The name of our package
>  (setq package-maint-pkg "dvc")
>  

Just avoid putting commented debug code in your submissions, but
otherwise, the patch seems OK.

-- 
Matthieu

_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to