On Friday, August 25, 2006 at 16:01:17, Matthieu Moy wrote: > Robert Widhopf-Fenk <[EMAIL PROTECTED]> writes: > > > This was the first time I created a bundle and from the > > docs I was not really sure how to use bundle-revisions ... > > No harm ;-). > > Next step: it's better to use attachments, with a MIME type > "text/something", like text/plain or text/x-patch, this way, you > make sure you don't modify the bundle accidentally, and the > beginning and end of it are more clear.
Hmm, I used "text/plain", do you mean I should not use "Content-Disposition: inline;" but "Content-Disposition: attachment;" or that I should not use "text/plain"? > (in particular, here, you've added a space in the beginning of the > first line, I'm not sure the bundle parser is robust to that). I redirected the output of bzr to a file and attached that file. There is no extra space, and I doubt that your Gnus is broken, so it must be a problem of another tool you are using for mail processing or magic. I checked https://mail.gna.org/public/dvc-dev/2006-08.partial.mbox.gz and there is no extra space, see ,---- | --lrNN+GXP3E | Content-Type: text/plain; charset=us-ascii | Content-Disposition: inline; | filename="xemacs-compilation-fixes.diff" | Content-Transfer-Encoding: 7bit | | # Bazaar revision bundle v0.8 | # | # message: | # Reverted fix for auto-autoload.el generation for XEmacs. `---- > Side note: when you include several revisions, "bzr bundle" will > give the human-readable diff on top, and uuencodeed representation > of the intermediate revisions in between. This makes review easy, > but keeps all the advantages of a "bzr merge" (in particular, > subsequent merges will work without conflicts). > > > === modified file lisp/dvc-build.el // > > last-changed:[EMAIL PROTECTED] ... -0a0b62f6f2c88ef0 > > --- lisp/dvc-build.el > > +++ lisp/dvc-build.el > > @@ -34,6 +34,8 @@ > > (push srcdir load-path) > > (push loaddir load-path) > > > > +;(setq debug-on-error t) > > + > > ;; The name of our package > > (setq package-maint-pkg "dvc") > > > > Just avoid putting commented debug code in your submissions, but > otherwise, the patch seems OK. It was left on purpose, as it might be helpful in the future. ;-) Bye Robert _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
