Robert Widhopf-Fenk <[EMAIL PROTECTED]> writes: > On Friday, August 25, 2006 at 16:01:17, Matthieu Moy wrote: >> Robert Widhopf-Fenk <[EMAIL PROTECTED]> writes: >> >> > This was the first time I created a bundle and from the >> > docs I was not really sure how to use bundle-revisions ... >> >> No harm ;-). >> >> Next step: it's better to use attachments, with a MIME type >> "text/something", like text/plain or text/x-patch, this way, you >> make sure you don't modify the bundle accidentally, and the >> beginning and end of it are more clear. > > Hmm, I used "text/plain", do you mean I should not use
Oh, my mistake. I saw your file inline without any Gnus buttons, I didn't notice it was actually a separate part. > "Content-Disposition: inline;" > > but > > "Content-Disposition: attachment;" It probably doesn't make much difference. Well, it helps people like me who are not able to see that you did the right thing ;-). > or that I should not use "text/plain"? I suppose test/x-patch would have shown a button for me. But the important is to have it text/* so that almost any mailer display it inline for review. >> (in particular, here, you've added a space in the beginning of the >> first line, I'm not sure the bundle parser is robust to that). > > I redirected the output of bzr to a file and attached > that file. > > There is no extra space, and I doubt that your Gnus is > broken, so it must be a problem of another tool you are > using for mail processing or magic. On my box, it displays like this : ,---- | So here is a bundle including both other, i.e. the output of | "bzr bundle-revisions". | | Robert | | # Bazaar revision bundle v0.8 | # | # message: | # Reverted fix for auto-autoload.el generation for XEmacs. | # Seems they were not generated for some other strange reason as it works now. `---- There is actually a space, but in the end of the previous part, after your signature. >> > === modified file lisp/dvc-build.el // >> > last-changed:[EMAIL PROTECTED] ... -0a0b62f6f2c88ef0 >> > --- lisp/dvc-build.el >> > +++ lisp/dvc-build.el >> > @@ -34,6 +34,8 @@ >> > (push srcdir load-path) >> > (push loaddir load-path) >> > >> > +;(setq debug-on-error t) >> > + >> > ;; The name of our package >> > (setq package-maint-pkg "dvc") >> > >> >> Just avoid putting commented debug code in your submissions, but >> otherwise, the patch seems OK. > > It was left on purpose, as it might be helpful in the future. ;-) Ah, yes, in dvc-build.el, it can be convenient, 'cause you can't just M-x toggle-debug-on-error RET. I'm afraid you got it all right then ;-). -- Matthieu _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
