On Friday, February 28, 2003, at 02:49 PM, Raymond Irving wrote:
--- Benoit Marchant <[EMAIL PROTECTED]> wrote:So what about tweaking addChild(c,alias) method to addChild(c,alias,inline). Then you can specify inline as true, and we would default to no, which means it would be transparent to the current api.
I disagree with adding an inline argument to the addChild.
Could you explain ?
I would however suggest that a isInline property be used:
lyr.isInline=true;
or we could modify the setID() function to use the inline agrument.
like setID(anId, true) if it's for an inline layer ? Why not.
I'm all for including that in DynElement.prototype.addChild instead of overwriting it.
We can "override" DynElement.prototype.addChild in the dynlayer_inline.js, t should work as long as you include that file, right ?
Yes but not necessary.
DynLayer.prototype.assignInlineElement = function () { if (this.parent && !this.elm) { //I'm not sure we want to call that as onprecreate was usually used to do setHTML which doesn't make sense here since the html already exists. Comments ? //DynElement._flagEvent(this,'precreate'); DynLayer._assignElement(this); DynLayer._updateValues(this); DynElement._flagEvent(this,'create'); } }
Use _createInline() isstead of assignInlineElement()
Ok for the name closer to the current naming.
function(c,alias,inline) {
function(c,alias) {
if (!c) return dynapi.debug.print("Error: no object sent to [DynLayer].addChild()"); if (c.isChild) c.removeFromParent(); c.isChild = true; c.parent = this; if (c._saveAnchor) { c.setAnchor(c._saveAnchor); delete c._saveAnchor; } if(alias) this[alias]=c; if (this._created) { if(!inline) c._create();
if(!c.isLine) c._create();
else { c.assignInlineElement();
c._createInline();
} this.children[this.children.length] = c; return c; };
I didn't get any answer from Jordi Ministral regarding the developer access.
Benoit
-- Raymond Irving
__________________________________________________ Do you Yahoo!? Yahoo! Tax Center - forms, calculators, tips, more http://taxes.yahoo.com/
------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dynapi-Dev mailing list [EMAIL PROTECTED] http://www.mail-archive.com/[EMAIL PROTECTED]/
------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dynapi-Dev mailing list [EMAIL PROTECTED] http://www.mail-archive.com/[EMAIL PROTECTED]/