On Monday, March 3, 2003, at 08:09 PM, Raymond Irving wrote:



--- Benoit Marchant <[EMAIL PROTECTED]> wrote:
Agreed, but make sure you test for the existence of
this._createInLine() before calling it, and
eventually raise if the
layer is setInline, but the fucntion isn't defined.
I guess the inline
schem still need to be optional, right ?

Yes, but I'm making some smooth changes that will not require me to check for _createInline(), in fact you might not event have to use a dynapi.document.assignInlineElement() at all. More on this later.
I think the need for a dynapi.document.assignInlineElement() is much lowered with the combination of setID(id,isInline) and the use of isInline in addChild, right ?
We can still have it, sure.


I've tested it in the inline example, fixed a few bugs. Shall I wait on getting my cvs access, or can I send you what I have ?

Benoit




PS. When I'm done I'll upload the changes to cvs


--
Raymond  Irving



Benoit



PS. Also remember that We'll now be using DynLayerInline instead of DynLayer_inline

--
Raymond Irving



--- Benoit Marchant <[EMAIL PROTECTED]> wrote:
Ok, so do we add the isInline argument to setID
in
event.js where we do
use it in addChild ?

p.DynObjectSetID = DynObject.setID
p.setID = function(id,isInline) {
        p.DynObjectSetID(id);
        this.isInline = isInline;
};

Make sense ?

Benoit

isInline
On Saturday, March 1, 2003, at 07:24  PM, Raymond
Irving wrote:


--- Benoit Marchant <[EMAIL PROTECTED]> wrote:
You didn't tell why you don't like adding an
argument to addChild ?

Well, I believe that using setID() will allows
us
to
better set the isInline property. This will
offer
greater flexiblity if we need to test if a
layer's
elm
already exist or if we need to do other stuff
with
inline layers. All we have to do is to check if
isLine
is true and we will know if the layers has an
inline
elm.

--
Raymond Irving



Benoit


On Friday, February 28, 2003, at 03:09 PM,
Raymond
Irving wrote:


--- Doug Melvin <[EMAIL PROTECTED]>
wrote:
how about .bindInline('inlineID'); ?
thus binding yer dynlayer to an inline
layer..

Hmmm...


setID(newID,true) if it's for an inline is
more
flexible.


If done before adding the layer to the
document
then
when you do add, it
would bind the inline layer..
if done after the dynlayer has been added..
then
delete the dynamically
created components and bind to the inline
layer
----- Original Message -----
From: "Raymond Irving" <[EMAIL PROTECTED]>
To: "DynAPI-Dev"
<[EMAIL PROTECTED]>
Sent: Friday, February 28, 2003 2:49 PM
Subject: Re: [Dynapi-Dev] New
TemplateDesigner
Object for 3.0



--- Benoit Marchant <[EMAIL PROTECTED]>
wrote:
So what about tweaking addChild(c,alias)
method
to
addChild(c,alias,inline). Then you can
specify
inline as true, and we
would default to no, which means it would
be
transparent to the current
api.

I disagree with adding an inline argument to
the
addChild. I would however suggest that a
isInline
property be used:

lyr.isInline=true;

or we could modify the setID() function to
use
the
inline agrument.

We can "override"
DynElement.prototype.addChild in the
dynlayer_inline.js, t should work
as long as you include that file, right ?

Yes but not necessary.


DynLayer.prototype.assignInlineElement =
function ()
{
     if (this.parent && !this.elm) {
         //I'm not sure we want to call
that
as
onprecreate was usually
used to do setHTML which doesn't make sense
here
since the html already
exists. Comments ?
//DynElement._flagEvent(this,'precreate');
DynLayer._assignElement(this);
DynLayer._updateValues(this);
DynElement._flagEvent(this,'create');
     }
}

Use _createInline() isstead of
assignInlineElement()

function(c,alias,inline) {

function(c,alias) {


if (!c) return dynapi.debug.print("Error:
no
object
sent to
[DynLayer].addChild()");
if (c.isChild) c.removeFromParent();
c.isChild = true;
c.parent = this;
if (c._saveAnchor) {
c.setAnchor(c._saveAnchor);
delete c._saveAnchor;

=== message truncated ===


__________________________________________________ Do you Yahoo!? Yahoo! Tax Center - forms, calculators, tips, more http://taxes.yahoo.com/


-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger
for complex code. Debugging C/C++ programs can leave you feeling lost and
disoriented. TotalView can help you find your way. Available on major UNIX
and Linux platforms. Try it free. www.etnus.com
_______________________________________________
Dynapi-Dev mailing list
[EMAIL PROTECTED]
http://www.mail-archive.com/[EMAIL PROTECTED]/





-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger for complex code. Debugging C/C++ programs can leave you feeling lost and disoriented. TotalView can help you find your way. Available on major UNIX and Linux platforms. Try it free. www.etnus.com
_______________________________________________
Dynapi-Dev mailing list
[EMAIL PROTECTED]
http://www.mail-archive.com/[EMAIL PROTECTED]/

Reply via email to