On 10/08/2010 04:36 PM, Brandeburg, Jesse wrote: > On Fri, 8 Oct 2010, Chris Friesen wrote:
>> I've attached a possible patch based on this premise, and I also moved >> the interrupt disable code to >> ixgbe_msix_clean_tx/ixgbe_msix_clean_rx/ixgbe_msix_clean_many where >> there are comments which seem to indicate the proper place to do the >> disabling. This also means that we only call disable once per interrupt >> rather than every time napi calls the poll function. > > the patch itself looks okay, ut I don't understand what you mean by the > last line of the above paragraph. Originally I'd been looking at disabling the interrupts in ixgbe_clean_rxtx_many() just because that's where they get re-enabled, but that potentially gets called by napi multiple times per interrupt. ixgbe_msix_clean_many() is only called once per interrupt, and also has a comment indicating that interrupts should be disabled so it looked like the proper place to put the code. > seems reasonable, it should work okay. Does it fix the problem? It seems > there must be a race between when the interrupt gets re-enabled and when > the hardware clears the mask via EIAM on the next interrupt. I'm about to give it a try. The problem can take hours to reproduce, so we won't know for a day or so whether it's really gone. Thanks, Chris -- Chris Friesen Software Developer GENBAND chris.frie...@genband.com www.genband.com ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
