Fedor Karpelevitch wrote:
> that's not the parser, that's the RULE!
If that's the rule, then change the rule.
I'm a human (pronounce it the Ferengi way : YU-MAN), with a small brain,
and I expect IDEA to make my life easier.
After 'extracting variable' on "a" + "b", for 'all occurrences',
on
>>>>
>>>> System.out.println(
>>>> "a" + "b"
>>>> + "a" + "b"
>>>> );
>>>> System.out.println(
>>>> "a" + "b"
>>>> + "a" + "b"
>>>> );
>>>>
I expect to get
>>>>After:
>>>>
>>>> String COMMON = "a" + "b";
>>>> System.out.println(
>>>> COMMON
>>>> + COMMON
>>>> );
>>>> System.out.println(
>>>> COMMON
>>>> + COMMON
>>>> );
and not
>>>>After:
>>>>
>>>> String COMMON = "a" + "b";
>>>> System.out.println(
>>>> COMMON
>>>> + "a" + "b"
>>>> );
>>>> System.out.println(
>>>> COMMON
>>>> + "a" + "b"
>>>> );
If that's the rule, then change the rule.
Alain Ravet
Fedor Karpelevitch wrote:
> that's not the parser, that's the RULE!
> Association is significant. In this partivcular case it makes not
> difference, but in general it does, so ignoring it is not correct.
>
> --
> fedor.
>
> ----
> Newton's Fourth Law: Every action has an equal and opposite satisfaction.
>
>
>
>>-----Original Message-----
>>From: Neil Galarneau [mailto:[EMAIL PROTECTED]]
>>Sent: Monday, March 25, 2002 6:24 AM
>>To: [EMAIL PROTECTED]
>>Subject: Re: [Eap-list] "extract variable" does not detect all
>>occurences
>>
>>
>>So are you proposing that Intellij rename the feature from
>>"replace all occurrences" to
>>"replace all occurrences that we can easily see with our
>>current parser" :-) ?
>>
>>Neil
>>
>>At 10:06 AM 3/24/2002 -0800, you wrote:
>>
>>>As far as I renmember "+" associates right-to-left and so
>>>
>>>"a"+"b"+"a"+b" is in fact (("a"+"b")+"a")+b" so the second
>>>
>>"a"+b" is broken
>>
>>>apart and need not be replaced. Does it work correctly for
>>>
>>"a"+"b"+("a"+b") ?
>>
>>>If it does not then that is probably indeed a bug...
>>>
>>>fedor.
>>>
>>>On Sunday 24 March 2002 04:02 am, you wrote:
>>>
>>>>If you "extract variable", and "replace all occurrences" on
>>>> "a" + "b"
>>>>in the code below,
>>>>IDEA will only detect 2 occurences, and not the 4 possibles ;
>>>>
>>>>
>>>>Before:
>>>>
>>>> System.out.println(
>>>> "a" + "b"
>>>> + "a" + "b"
>>>> );
>>>> System.out.println(
>>>> "a" + "b"
>>>> + "a" + "b"
>>>> );
>>>>
>>>>After:
>>>>
>>>> String COMMON = "a" + "b";
>>>> System.out.println(
>>>> COMMON
>>>> + "a" + "b"
>>>> );
>>>> System.out.println(
>>>> COMMON
>>>> + "a" + "b"
>>>> );
_______________________________________________
Eap-list mailing list
[EMAIL PROTECTED]
http://www.intellij.com/mailman/listinfo/eap-list
