Just a quick note about the OpenSSL token build; this is the behavior that I would like to see:
If openssl-devel is installed and the user does not specify --enable-openssl for ./configure, build the OpenSSL token. If openssl-devel is installed and the user specifies --enable-openssl for ./configure, build the OpenSSL token. If openssl-devel is not installed and the user does not specify --enable-openssl for ./configure, do not build the OpenSSL token (right now, ./configure bombs out). If openssl-devel is not installed and the user specifies --enable-openssl for ./configure, bomb out. Thanks, Mike On Tue, Oct 16, 2007 at 07:26:54AM +0200, Alon Bar-Lev wrote: > On Tuesday 16 October 2007, Michael Halcrow wrote: > > ecryptfs-utils-27 is available, incorporating the changes you sent > > last week: > > > > http://downloads.sourceforge.net/ecryptfs/ecryptfs-utils-27.tar.bz2 > > > > I recently received my kernel.org account, and I will be moving the > > code base to an account there this week. > > > > Mike > > > > Great! > > Questions.... > 1. Why didn't you use "make dist" in order to create the package? You have > junk files again.... > I will be happy to solve any issue you have with "make dist", but please > don't distribute temp file > csope files etc... > 2. config.h should be included before any other include, so in the future you > may #ifdef include file... > Most projects using autoconf/automake doing this by convention. > 3. You have removed the --prompt-prog argument? You merged all the other > stuff, but we cannot set the > prog now. > 4. My latest autoconf workaround is also missing. > > I am sorry my coding conventions are some different, I will try to adjust, I > understand the compound > logic, but not the space logic... :) > > Attached a patch with remaining chunks. > If you can add the pin-prog parameter and release a new tarball, I can ask > people to start testing > pkcs11 key module, we will get more users helping to stabilize eCryptfs. > > Best Regards, > Alon Bar-Lev. > > --- > > diff -urNp ecryptfs-utils-27/configure.ac ecryptfs-utils-27.n1/configure.ac > --- ecryptfs-utils-27/configure.ac 2007-10-15 23:54:56.000000000 +0200 > +++ ecryptfs-utils-27.n1/configure.ac 2007-10-16 07:15:14.000000000 +0200 > @@ -289,11 +289,11 @@ AM_CONDITIONAL([BUILD_DOCS_GEN], [test " > > # workaround for <autoconf-2.60 > if test -z "${docdir}"; then > - docdir="\${datarootdir}/doc/${PACKAGE_NAME}" > + docdir="\$(datarootdir)/doc/\$(PACKAGE_NAME)" > AC_SUBST([docdir]) > fi > if test -z "${htmldir}"; then > - htmldir="\${docdir}" > + htmldir="\$(docdir)" > AC_SUBST([htmldir]) > fi > # end workaround > diff -urNp ecryptfs-utils-27/src/daemon/main.c > ecryptfs-utils-27.n1/src/daemon/main.c > --- ecryptfs-utils-27/src/daemon/main.c 2007-10-15 23:54:56.000000000 > +0200 > +++ ecryptfs-utils-27.n1/src/daemon/main.c 2007-10-16 07:15:47.000000000 > +0200 > @@ -251,6 +251,7 @@ int main(int argc, char **argv) > { "pidfile\0\tSet pid file name", required_argument, NULL, 'p' > }, > { "foreground\0\t\tDon't fork into background", no_argument, > NULL, 'f' }, > { "chroot\0\t\tChroot to directory", required_argument, NULL, > 'C' }, > + { "prompt-prog\0Program to execute for user prompt", > required_argument, NULL, 'R' }, > { "version\0\t\t\tShow version information", no_argument, NULL, > 'V' }, > { "help\0\t\t\tShow usage information", no_argument, NULL, 'h' > }, > { NULL, 0, NULL, 0 } > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > eCryptfs-devel mailing list > eCryptfs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ecryptfs-devel
pgp8zVOOAAmRf.pgp
Description: PGP signature
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________ eCryptfs-devel mailing list eCryptfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ecryptfs-devel
