On Tue, Oct 16, 2007 at 07:26:54AM +0200, Alon Bar-Lev wrote: > Questions.... > 1. Why didn't you use "make dist" in order to create the package? > You have junk files again....
I have my own tarball-making script that I just haven't gotten around
to not using yet. I will try make dist next time.
> 2. config.h should be included before any other include, so in the
> future you may #ifdef include file...
> Most projects using autoconf/automake doing this by convention.
I put it before every *local* set of #include's ("" rather than <>
reference). This follows the convention that package-specific #include
"" directives all come after the system-wide #include <>
directives. Is it ever the case that we should want to play with
#ifdef's in system-wide .h files? If any system-wide .h files require
that, well, that just seems really sloppy to me.
> 3. You have removed the --prompt-prog argument? You merged all the
> other stuff, but we cannot set the prog now.
There is a lot of traffic on this patch set, so I probably just missed
that patch.
> 4. My latest autoconf workaround is also missing.
I made the release before I got your message with that patch. It will
be in the next release.
> I am sorry my coding conventions are some different, I will try to
> adjust, I understand the compound logic, but not the space
> logic... :)
In general, we try to adhere to kernel coding standards in all code,
kernel or userspace. With regard to spaces, I like to try to minimize
the number of lines so as to make it more likely that the entire
function will always fit in a single screen.
I will merge your most recent patch, along with the OpenSSL token
build patch, and make another release.
Thanks,
Mike
pgpsn30MSfFQQ.pgp
Description: PGP signature
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________ eCryptfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ecryptfs-devel
