On 10/18/07, Michael Halcrow <[EMAIL PROTECTED]> wrote:
> On Tue, Oct 16, 2007 at 07:26:54AM +0200, Alon Bar-Lev wrote:
> > Questions....
> > 1. Why didn't you use "make dist" in order to create the package?
> > You have junk files again....
>
> I have my own tarball-making script that I just haven't gotten around
> to not using yet. I will try make dist next time.
This would be great!
But please before releasing see if anything is missing.
For example, do you wish to distribute C files that are not built? The
testcases also have no reference etc...
> > 2. config.h should be included before any other include, so in the
> > future you may #ifdef include file...
> > Most projects using autoconf/automake doing this by convention.
>
> I put it before every *local* set of #include's ("" rather than <>
> reference). This follows the convention that package-specific #include
> "" directives all come after the system-wide #include <>
> directives. Is it ever the case that we should want to play with
> #ifdef's in system-wide .h files? If any system-wide .h files require
> that, well, that just seems really sloppy to me.
No it does not.
For example:
#ifdef HAVE_LOCALE_H
#include <locale.h>
#endif
#ifdef HAVE_LIBREADLINE_H
#include <readline/readline.h>
#endif
I can fine mode examples. The whole point of autoconf is to detect
these includes and allow you to use the system wide library or to
provide an alternative.
Because config.h contains only configuration directives, it is
intended to be used as first include so you can consult its values at
early stage.
For now, it is not so important, later on, as you add more
functionality you will see that it is usable.
> I will merge your most recent patch, along with the OpenSSL token
> build patch, and make another release.
Great!
Now we see if "make dist" is usable and finish new build system current overall.
Best Regards,
Alon Bar-Lev.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
eCryptfs-devel mailing list
eCryptfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ecryptfs-devel
