I did not receive the patch 42. I have only gotten 38,39,40,41. OK, If this mtrr setting stored in ACPI NVS is for CpuS3DataDxe to store into SMRAM, that's fine.
Then, another question, what's requirement to save MTRR setting into ACPI NVS on this case? And need one PCD to switch on/off it? Jeff -----Original Message----- From: Paolo Bonzini [mailto:[email protected]] On Behalf Of Paolo Bonzini Sent: Tuesday, July 28, 2015 2:52 PM To: Fan, Jeff; Laszlo Ersek; [email protected] Cc: Chen Fan; Justen, Jordan L Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block On 28/07/2015 08:05, Fan, Jeff wrote: > Ersek, > > I have one comment for PCD PcdCpuSyncMtrrToAcpiNvs. > > I knew OvmfPkg implemented LockBox based on ACPI NVS. Saving MTRR setting in > AcpiNVS is OK for OvmfPkg. If I understand correctly what you are saying, the AcpiNVS block is only used for communication from CpuDxe to CpuS3DataDxe in patch 42. CpuS3DataDxe saves the MTRR in SMRAM during SmmReadyToLockEventNotify() and PiSmmCpuDxeSmm restores them during S3 resume. So Laszlo's patches are doing exactly the "safe" thing, even though they are not using LockBox. > But other platform may want to use more safe solution to save MTRR based on > in SMM. > > I think that, for long term, saving MTRR setting by LockBox instead of > using ACPI NVS memory directly. Then, different platforms could > provide the different LockBox solutions. For short term, still saving > MTRR setting in ACPI NVS in CpuDxe, and removing this PCD. That means > we could CpuDxe implementation to use the long term solution in the > future and needn't to remove one un-used PCD more. The PCD is consumed in CPUS3DataDxe. Paolo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
