On 07/28/15 09:33, Paolo Bonzini wrote: > > > On 28/07/2015 09:09, Fan, Jeff wrote: >> I did not receive the patch 42. I have only gotten 38,39,40,41. >> >> OK, If this mtrr setting stored in ACPI NVS is for CpuS3DataDxe to >> store into SMRAM, that's fine. >> >> Then, another question, what's requirement to save MTRR setting into >> ACPI NVS on this case? And need one PCD to switch on/off it? > > Do you mean it could be BootServicesData? I'll let Laszlo answer this.
That is a good point, yes. I *think* it could be BootServicesData. However, the Quark distribution's equivalent CPU driver code uses AcpiNVS for this purpose, and I wanted the port to be as close as possible to the original (so that reviewers would face the least possible differences). > The PCD is there to skip this code if OVMF is built without SMRAM support. Yes, and for all other client platforms that include UefiCpuPkg/CpuDxe but do not include any SMM-related stuff. They would not consume the data allocated and maintained by UefiCpuPkg/CpuDxe. Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
