On 07/28/15 09:09, Fan, Jeff wrote: > I did not receive the patch 42. I have only gotten 38,39,40,41.
I CC people on a given patch if I'd like to draw their personal, special attention to that patch. Therefore, a maintainer of a top-level package, affected by the patch, is always CC'd. However, it doesn't mean that a reviewer should ignore all other patches in a series. The full series is available on edk2-devel, which (I expect) you are subscribed to. If you'd like to locate the patches that you have been CC'd on among those patches that you have not been CC'd on, you can search for the former patches' message-ids on the list, or (much more simply) search for their subjects. > OK, If this mtrr setting stored in ACPI NVS is for CpuS3DataDxe to store into > SMRAM, that's fine. Thanks. > Then, another question, what's requirement to save MTRR setting into > ACPI NVS on this case? I explained this in my earlier email. The AcpiNVS block maintains an up-to-date copy of the MTRR settings, for whenever PiSmmCpuDxeSmm will need it. > And need one PCD to switch on/off it? That's a FeaturePCD. No client platform in edk2 other than OvmfPkg will need this functionality from UefiCpuPkg/CpuDxe for a while, so we should allow them *not* to take a hit, in code size and in AcpiNVS allocation. Thanks Laszlo > > Jeff > > -----Original Message----- > From: Paolo Bonzini [mailto:[email protected]] On Behalf Of Paolo > Bonzini > Sent: Tuesday, July 28, 2015 2:52 PM > To: Fan, Jeff; Laszlo Ersek; [email protected] > Cc: Chen Fan; Justen, Jordan L > Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR > settings to AcpiNVS memory block > > > > On 28/07/2015 08:05, Fan, Jeff wrote: >> Ersek, >> >> I have one comment for PCD PcdCpuSyncMtrrToAcpiNvs. >> >> I knew OvmfPkg implemented LockBox based on ACPI NVS. Saving MTRR setting in >> AcpiNVS is OK for OvmfPkg. > > If I understand correctly what you are saying, the AcpiNVS block is only used > for communication from CpuDxe to CpuS3DataDxe in patch 42. > CpuS3DataDxe saves the MTRR in SMRAM during SmmReadyToLockEventNotify() and > PiSmmCpuDxeSmm restores them during S3 resume. So Laszlo's patches are doing > exactly the "safe" thing, even though they are not using LockBox. > >> But other platform may want to use more safe solution to save MTRR based on >> in SMM. >> >> I think that, for long term, saving MTRR setting by LockBox instead of >> using ACPI NVS memory directly. Then, different platforms could >> provide the different LockBox solutions. For short term, still saving >> MTRR setting in ACPI NVS in CpuDxe, and removing this PCD. That means >> we could CpuDxe implementation to use the long term solution in the >> future and needn't to remove one un-used PCD more. > > The PCD is consumed in CPUS3DataDxe. > > Paolo > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
