As mentioned, It's one large commit onto EDK2 as AcpicaPkg. It has only two lines of changes to the ACPICA code, and the intent was to get those two lines rolled into ACPICA if possible. I propose that this get pulled into AppPkg since the code is modelled after those apps. My approach was to port Acpidump as a standard-lib-consuming shell application. I don't know any of the licensing details....
-----Original Message----- From: Andrew Fish [mailto:[email protected]] Sent: Tuesday, August 11, 2015 7:05 AM To: Laszlo Ersek Cc: Shubha Ramani; Smith, Jonathan D; [email protected] Subject: Re: [edk2] Status of porting acpidump to edk2 ? > On Aug 11, 2015, at 5:56 AM, Laszlo Ersek <[email protected]> wrote: > > On 08/11/15 05:52, Andrew Fish wrote: >> >>> On Aug 10, 2015, at 7:33 PM, Shubha Ramani <[email protected]> wrote: >>> >>> I know people were attempting to port acpidump from https://www.acpica.org/ >>> to EDK2. Any success ? I need it desperately. >> >> If you look at the mailing list history [email protected] >> <mailto:[email protected]> posted a Windows port to the mailing >> list. > > I saw it. Unfortunately it wasn't a patch formatted and sent with > git-format-patch / git-send-email. > > (Maybe that makes sense. The source code is huge; plus, according to > Jonathan's repo, it's just one large commit, > <https://github.com/jnthsmth/edk2/commit/c0882f6bd53afd59b1d18a15bbf5a > 92224abfb7f>.) > > Anyway, where should the utility live in the edk2 tree? The patch at > the moment introduces a new top-level package, AcpicaPkg. That leaves > it without a maintainer who could review it (or at least approve the > addition). Also, for a new top level package, License.txt / > Contributions.txt would be necessary. > It ended up as a package as it used the .DEC file to add the include paths for the existing code. [Includes] # acpica paths source/include source/include/platform source/tools/acpidump Also, I at some point we need to understand the license of the existing code, and what that means? Does it need a separate package? Can we convert it to BSD? > But, I think it would be best to add this toolset under > MdeModulePkg/Application/. MdeModulePkg is where AcpiTableDxe lives > (implementing EFI_ACPI_TABLE_PROTOCOL, and conditionally > EFI_ACPI_SDT_PROTOCOL too). Code (example code or otherwise) for > installing actual tables can also be found there (AcpiPlatformDxe, > BootGraphicsResourceTableDxe, IScsiDxe, etc). > The current port is a Shell App, and it requires the StdLib. [Packages] StdLib/StdLib.dec MdePkg/MdePkg.dec ShellPkg/ShellPkg.dec Generally MdeModulePkg applications only depend on the MdePkg, and the MdeModulePkg. Thanks, Andrew Fish > Thanks > Laszlo > >> >> Thanks, >> >> Andrew Fish >> >> >>> Thanks, >>> Shubha Shubha D. [email protected] [email protected] >>> _______________________________________________ >>> edk2-devel mailing list >>> [email protected] >>> https://lists.01.org/mailman/listinfo/edk2-devel >> >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.01.org/mailman/listinfo/edk2-devel >> > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
