We'll follow-up this week. Vincent PS Have to teach your email client, Fish, to hit my Intel email, not Gmail, acct :) -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Smith, Jonathan D Sent: Tuesday, August 11, 2015 9:59 AM To: Andrew Fish; Vincent Zimmer; edk2-devel@lists.01.org; Kinney, Michael D; Hauch, Larry Subject: Re: [edk2] Status of porting acpidump to edk2 ?
Maybe Larry Hauch or Mike Kinney would know who to talk to about this? -----Original Message----- From: Andrew Fish [mailto:af...@apple.com] Sent: Tuesday, August 11, 2015 9:21 AM To: Vincent Zimmer Cc: Smith, Jonathan D Subject: Re: [edk2] Status of porting acpidump to edk2 ? > On Aug 11, 2015, at 8:31 AM, Smith, Jonathan D <jonathan.d.sm...@intel.com> > wrote: > > As mentioned, It's one large commit onto EDK2 as AcpicaPkg. It has only two > lines of changes to the ACPICA code, and the intent was to get those two > lines rolled into ACPICA if possible. I propose that this get pulled into > AppPkg since the code is modelled after those apps. My approach was to port > Acpidump as a standard-lib-consuming shell application. I don't know any of > the licensing details.... > Vincent, Since adding an ACPI dump command came up in the UEFI Forum meetings, and Intel lawyers came up with both sets of licenses…. Seems like a good idea to figure out a landing spot. Seems like the ACPICA website or edk2 are both options? Who is the person at Intel to figure this stuff out? Thanks, Andrew Fish > -----Original Message----- > From: Andrew Fish [mailto:af...@apple.com] > Sent: Tuesday, August 11, 2015 7:05 AM > To: Laszlo Ersek > Cc: Shubha Ramani; Smith, Jonathan D; edk2-devel@lists.01.org > Subject: Re: [edk2] Status of porting acpidump to edk2 ? > > >> On Aug 11, 2015, at 5:56 AM, Laszlo Ersek <ler...@redhat.com> wrote: >> >> On 08/11/15 05:52, Andrew Fish wrote: >>> >>>> On Aug 10, 2015, at 7:33 PM, Shubha Ramani <shubharam...@yahoo.com> wrote: >>>> >>>> I know people were attempting to port acpidump from >>>> https://www.acpica.org/ to EDK2. Any success ? I need it desperately. >>> >>> If you look at the mailing list history jonathan.d.sm...@intel.com >>> <mailto:jonathan.d.sm...@intel.com> posted a Windows port to the mailing >>> list. >> >> I saw it. Unfortunately it wasn't a patch formatted and sent with >> git-format-patch / git-send-email. >> >> (Maybe that makes sense. The source code is huge; plus, according to >> Jonathan's repo, it's just one large commit, >> <https://github.com/jnthsmth/edk2/commit/c0882f6bd53afd59b1d18a15bbf5 >> a >> 92224abfb7f>.) >> >> Anyway, where should the utility live in the edk2 tree? The patch at >> the moment introduces a new top-level package, AcpicaPkg. That leaves >> it without a maintainer who could review it (or at least approve the >> addition). Also, for a new top level package, License.txt / >> Contributions.txt would be necessary. >> > > It ended up as a package as it used the .DEC file to add the include paths > for the existing code. > > [Includes] > # acpica paths > source/include > source/include/platform > source/tools/acpidump > > Also, I at some point we need to understand the license of the existing code, > and what that means? Does it need a separate package? Can we convert it to > BSD? > >> But, I think it would be best to add this toolset under >> MdeModulePkg/Application/. MdeModulePkg is where AcpiTableDxe lives >> (implementing EFI_ACPI_TABLE_PROTOCOL, and conditionally >> EFI_ACPI_SDT_PROTOCOL too). Code (example code or otherwise) for >> installing actual tables can also be found there (AcpiPlatformDxe, >> BootGraphicsResourceTableDxe, IScsiDxe, etc). >> > > The current port is a Shell App, and it requires the StdLib. > > [Packages] > StdLib/StdLib.dec > MdePkg/MdePkg.dec > ShellPkg/ShellPkg.dec > > > Generally MdeModulePkg applications only depend on the MdePkg, and the > MdeModulePkg. > > Thanks, > > Andrew Fish > >> Thanks >> Laszlo >> >>> >>> Thanks, >>> >>> Andrew Fish >>> >>> >>>> Thanks, >>>> Shubha Shubha D. ramanishubharam...@gmail.com >>>> shubharam...@yahoo.com >>>> _______________________________________________ >>>> edk2-devel mailing list >>>> edk2-devel@lists.01.org >>>> https://lists.01.org/mailman/listinfo/edk2-devel >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >>> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
