On 09/25/15 03:22, Qiu Shumin wrote: > Cc: Laszlo Ersek <[email protected]> > Cc: Jaben Carsey <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jaben Carsey <[email protected]> > Reviewed-by: Qiu Shumin <[email protected]> > --- > ShellPkg/ShellPkg.dsc | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc > index c2ce4f9..44c53c5 100644 > --- a/ShellPkg/ShellPkg.dsc > +++ b/ShellPkg/ShellPkg.dsc > @@ -1,7 +1,7 @@ > ## @file > # Shell Package > # > -# Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.<BR> > # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the > BSD License > @@ -73,10 +73,18 @@ > !endif #$(NO_SHELL_PROFILES) > > [Components] > + # > + # Build all the libraries when building this package. > + # This helps developers test changes and how they affect the package. > + # > ShellPkg/Library/UefiShellLib/UefiShellLib.inf > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > - ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf > ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > + > ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf > + > ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > + ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > + > ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > + ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf > > ShellPkg/Library/UefiDpLib/UefiDpLib.inf { > <LibraryClasses> >
As far as I understand, the idea here is to build those libraries unconditionally and separately that *may* not be built for Shell.inf itself, dependent on NO_SHELL_PROFILES, INCLUDE_DP, and INCLUDE_TFTP_COMMAND. That seems to make sense. However, the patch doesn't appear to cover UefiDpLib. Is that intentional? What does UefiDpLib do? Ah, wait I can see it; UefiDpLib is already built separately as well. Okay. Can you please update the commit message to state the purpose of the patch? You have already written that text, for the code itself, as a comment. For example: Subject: ShellPkg: Build all libraries unconditionally Body: This helps developers test changes and how they affect the package, regardless of the NO_SHELL_PROFILES, INCLUDE_DP, and INCLUDE_TFTP_COMMAND settings. Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
