On 09/25/15 14:30, Qiu Shumin wrote:
> Build all the optional libraries unconditionally so we can catch changes and 
> how they affect the package regardless of the NO_SHELL_PROFILES, INCLUDE_DP, 
> and INCLUDE_TFTP_COMMAND settings.
> 
> Difference with 1st version:
> List all the libraries explicitly.
> 
> Cc: Jaben Carsey <[email protected]>
> Cc: Laszlo Ersek <[email protected]>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qiu Shumin <[email protected]>
> Signed-off-by: Jaben Carsey <[email protected]>
> ---
>  ShellPkg/ShellPkg.dsc | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
> index c2ce4f9..33ee76c 100644
> --- a/ShellPkg/ShellPkg.dsc
> +++ b/ShellPkg/ShellPkg.dsc
> @@ -1,7 +1,7 @@
>  ##  @file
>  # Shell Package
>  #
> -# Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.<BR>
>  #
>  #    This program and the accompanying materials
>  #    are licensed and made available under the terms and conditions of the 
> BSD License
> @@ -73,10 +73,21 @@
>  !endif #$(NO_SHELL_PROFILES)
>  
>  [Components]
> +  #
> +  # Build all the libraries when building this package.
> +  # This helps developers test changes and how they affect the package.
> +  #
>    ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>    ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> -  ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
>    ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> +  ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
> +  ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
> +  ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
> +  
> ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
> +  
> ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> +  ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
> +  
> ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> +  ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf
>  
>    ShellPkg/Library/UefiDpLib/UefiDpLib.inf {
>      <LibraryClasses>
> 

Reviewed-by: Laszlo Ersek <[email protected]>

Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to