On Tue, Nov 03, 2015 at 11:16:34AM +0100, Ard Biesheuvel wrote: > Drop the call to ArmInvalidateDataCache () from the PrePi startup > sequence. This kind of data cache maintenance should not be performed > at the UEFI firmware level. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <[email protected]> > --- > ArmVirtPkg/PrePi/PrePi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/ArmVirtPkg/PrePi/PrePi.c b/ArmVirtPkg/PrePi/PrePi.c > index f9ad37427217..fe7612cec74b 100755 > --- a/ArmVirtPkg/PrePi/PrePi.c > +++ b/ArmVirtPkg/PrePi/PrePi.c > @@ -194,8 +194,6 @@ CEntryPoint ( > > // Data Cache enabled on Primary core when MMU is enabled. > ArmDisableDataCache (); > - // Invalidate Data cache > - ArmInvalidateDataCache (); > // Invalidate instruction cache > ArmInvalidateInstructionCache (); > // Enable Instruction Caches on all cores.
I'm not sure the I-cache maintenance is necessary either, given that we're already executing code that must have been fetched into the I-cache, but that really depends on what EDK's requirements are w.r.t. the state of the system. For this patch as is: Acked-by: Mark Rutland <[email protected]> Thanks, Mark. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
