On 03/18/16 18:45, David Woodhouse wrote: > On Fri, 2016-03-18 at 17:53 +0100, Laszlo Ersek wrote: >> >> (1) The commit message uses at least one non-ASCII character, the EM >> DASH (U+2014). Can you please replace it with a "--"? Yes, I know you >> hate me for asking this. Please just write me off as stupid and replace >> the character. > > No. This isn't 1994.
Really? I wouldn't know. If I look at what ISO C features we're allowed to use, we certainly seem to be stuck in 1995. Or, well, sometime before 1989, because we can't even use structure assignment. > If you wish to change it, go ahead. Thank you, I will. > Don't ask me > to do stupid things for no good reason. There is a good reason. You know it and you don't care about it. Not a problem; I'll fix up the commit message. >> (2) In the edk2 coding style, initialization of local variables is not >> permitted. Can you please add an assignment instead? > > Er, really? What insanity is this? Please ask your colleagues at Intel (but please also make sure that you don't take offense on their behalf, when you call their guidelines insane ;) ). > Where did these guidelines come from > and can they be fixed? Why would initialisation of local variables > *ever* be frowned upon? How do they make this stuff up? Please consult "EDK II C Coding Standards Specification.pdf", section 6.8 "C Function Layout": *Initializing a variable as part of its declaration is illegal.* (Emphasis theirs.) > >> (3) I tried to apply your patch nonetheless. It doesn't apply. I looked >> at the patch email that I saved from Thunderbird. The code section of >> the email contains =C2=A0 quoted-printable sequences. Since the charset >> is UTF-8 (according to the Content-Type header), 0xC2 0xA0 translates to >> U+00A0, "NO-BREAK SPACE". > > Hm, that would appear to be an Evolution bug. \o/ Finally something I'm not held responsible for! (BTW, why did you mail out the patch with Evolution, rather than git-send-email? Are you sure you are using the tools as they were intended? :)) > I think it triggers when > lines have trailing whitespace. I'll investigate. Thanks for pointing > it out. > > I can put it in a PR if you prefer... :) Works for me, but please send the pull request to the mailing list. I'll rebase the commit for the commit message fixup, and for adding my R-b, but I'll keep the base commit / history intact. Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
