On 03/22/16 00:24, Jordan Justen wrote: > On 2016-03-21 01:02:53, Laszlo Ersek wrote: >> On 03/20/16 17:58, Paulo Alcantara wrote: >>> This patch adds RamDiskDxe driver to OVMF through a new introduced flag >>> "RAMDISK_SUPPORT_ENABLE" which is disabled by default and may be enabled >>> with -DRAMDISK_SUPPORT_ENABLE=TRUE at build time. >>> >>> Cc: Jordan Justen <[email protected]> >>> Cc: Laszlo Ersek <[email protected]> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Paulo Alcantara <[email protected]> >>> --- >>> OvmfPkg/OvmfPkgIa32.dsc | 6 +++++- >>> OvmfPkg/OvmfPkgIa32.fdf | 3 +++ >>> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++ >>> OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++ >>> OvmfPkg/OvmfPkgX64.dsc | 6 +++++- >>> OvmfPkg/OvmfPkgX64.fdf | 3 +++ >>> 6 files changed, 23 insertions(+), 2 deletions(-) >> >> I think it should be fine to enable this unconditionally. Jordan, what >> do you think? >> > > So, this driver won't really take much action until the setup browser > is used to configure a ram disk? > > If so, it seems reasonable to include it by default. > > Does the setup browser actually have support for EFI_RAM_DISK_PROTOCOL > yet? (git grep EFI_RAM_DISK_PROTOCOL is a bit sparse)
As far as I understand, the setup browser doesn't need to be specifically aware. The RAM disk driver installs an HII form that lets the user configure stuff, and the callback function in the RAM disk driver creates the RAM disks. See RamDiskCallback() --> HiiCreateRamDisk() --> RamDiskRegister(). Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
