If the driver provides menus in setup, it only need to install the HII packages through HiiAddPackages and provide Config Access Protocol to let setup browser extract/route data from/to the driver. setup browser don't care any other information in the driver. RAM disk driver already provide them, so I think it can be supported by setup browser.
Thanks, Eric > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Paulo > Alcantara > Sent: Tuesday, March 22, 2016 8:14 AM > To: Justen, Jordan L > Cc: [email protected]; Laszlo Ersek > Subject: Re: [edk2] [PATCH] OvmfPkg: Add RAM disk support > > Hi Jordan, > > On Mon, Mar 21, 2016 at 8:24 PM, Jordan Justen > <[email protected]> wrote: > > On 2016-03-21 01:02:53, Laszlo Ersek wrote: > >> On 03/20/16 17:58, Paulo Alcantara wrote: > >> > This patch adds RamDiskDxe driver to OVMF through a new introduced flag > >> > "RAMDISK_SUPPORT_ENABLE" which is disabled by default and may be enabled > >> > with -DRAMDISK_SUPPORT_ENABLE=TRUE at build time. > >> > > >> > Cc: Jordan Justen <[email protected]> > >> > Cc: Laszlo Ersek <[email protected]> > >> > Contributed-under: TianoCore Contribution Agreement 1.0 > >> > Signed-off-by: Paulo Alcantara <[email protected]> > >> > --- > >> > OvmfPkg/OvmfPkgIa32.dsc | 6 +++++- > >> > OvmfPkg/OvmfPkgIa32.fdf | 3 +++ > >> > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++ > >> > OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++ > >> > OvmfPkg/OvmfPkgX64.dsc | 6 +++++- > >> > OvmfPkg/OvmfPkgX64.fdf | 3 +++ > >> > 6 files changed, 23 insertions(+), 2 deletions(-) > >> > >> I think it should be fine to enable this unconditionally. Jordan, what > >> do you think? > >> > > > > So, this driver won't really take much action until the setup browser > > is used to configure a ram disk? > > > > If so, it seems reasonable to include it by default. > > > > Does the setup browser actually have support for EFI_RAM_DISK_PROTOCOL > > yet? (git grep EFI_RAM_DISK_PROTOCOL is a bit sparse) > > I actually don't know whether the setup browser supports it or not, > but the RAM disk support is useful in many contexts -- either it's > being used by an application or driver. I added a flag to it because > it seems like an optional feature to me rather than something required > to boot a platform. Yet, it's working perfectly fine and solving my > problems :-) > > Paulo > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
