On 03/22/16 01:13, Paulo Alcantara wrote: > Hi Jordan, > > On Mon, Mar 21, 2016 at 8:24 PM, Jordan Justen > <[email protected]> wrote: >> On 2016-03-21 01:02:53, Laszlo Ersek wrote: >>> On 03/20/16 17:58, Paulo Alcantara wrote: >>>> This patch adds RamDiskDxe driver to OVMF through a new introduced flag >>>> "RAMDISK_SUPPORT_ENABLE" which is disabled by default and may be enabled >>>> with -DRAMDISK_SUPPORT_ENABLE=TRUE at build time. >>>> >>>> Cc: Jordan Justen <[email protected]> >>>> Cc: Laszlo Ersek <[email protected]> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Paulo Alcantara <[email protected]> >>>> --- >>>> OvmfPkg/OvmfPkgIa32.dsc | 6 +++++- >>>> OvmfPkg/OvmfPkgIa32.fdf | 3 +++ >>>> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++ >>>> OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++ >>>> OvmfPkg/OvmfPkgX64.dsc | 6 +++++- >>>> OvmfPkg/OvmfPkgX64.fdf | 3 +++ >>>> 6 files changed, 23 insertions(+), 2 deletions(-) >>> >>> I think it should be fine to enable this unconditionally. Jordan, what >>> do you think? >>> >> >> So, this driver won't really take much action until the setup browser >> is used to configure a ram disk? >> >> If so, it seems reasonable to include it by default. >> >> Does the setup browser actually have support for EFI_RAM_DISK_PROTOCOL >> yet? (git grep EFI_RAM_DISK_PROTOCOL is a bit sparse) > > I actually don't know whether the setup browser supports it or not, > but the RAM disk support is useful in many contexts -- either it's > being used by an application or driver. I added a flag to it because > it seems like an optional feature to me rather than something required > to boot a platform. Yet, it's working perfectly fine and solving my > problems :-)
I think that Ray's info in <http://thread.gmane.org/gmane.comp.bios.edk2.devel/9885/focus=9923> also supports the idea that the RAM disk driver should be included in OVMF unconditionally. So v2 should be submitted like that. However, since booting off of a RAM disk is not supported by IntelFrameworkModulePkg BDS, I assume your problems that this patch solves do not include booting off of a RAM disk. In that case, can you please elaborate on your use case in the v2 commit message? I prefer to see concrete justification when a feature is enabled. Also, can you post the patch from your HP email (the one in the S-o-b)? Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
