On 04/08/16 11:44, Ard Biesheuvel wrote:
> This introduces the FdtClientProtocol, which will be used to expose the
> device tree provided by the host to other DXE drivers.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <[email protected]>
> ---
>  ArmVirtPkg/ArmVirtPkg.dec               |   3 +
>  ArmVirtPkg/Include/Protocol/FdtClient.h | 108 ++++++++++++++++++++
>  2 files changed, 111 insertions(+)

> +
> +#define FDT_CLIENT_PROTOCOL_GUID { \
> +  0xE11FACA0, 0x4710, 0x4C8E, {0xA7, 0xA2, 0x01, 0xBA, 0xA2, 0x59, 0x1B, 
> 0x4C }\

Space before \ missing; can be fixed up without a repost.

> +  FDT_CLIENT_GET_CHOSEN_NODE               GetOrInsertChosenNode;

Typedef should also be renamed to FDT_CLIENT_GET_OR_INSERT_CHOSEN_NODE.
Can be fixed up without a repost.

With the above:
Reviewed-by: Laszlo Ersek <[email protected]>

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to