On 04/08/16 11:44, Ard Biesheuvel wrote:
> This implements a new DXE driver FdtClientDxe to produce the FDT client
> protocol based on a device tree image supplied by the virt host.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <[email protected]>
> ---
>  ArmVirtPkg/FdtClientDxe/FdtClientDxe.c   | 256 ++++++++++++++++++++
>  ArmVirtPkg/FdtClientDxe/FdtClientDxe.inf |  48 ++++
>  2 files changed, 304 insertions(+)

> +STATIC
> +EFI_STATUS
> +GetOrInsertChosenNode (
> +  IN  FDT_CLIENT_PROTOCOL     *This,
> +  OUT INT32                   *Node
> +  )
> +{
> +  INT32 NewNode;
> +
> +  ASSERT (mDeviceTreeBase != NULL);
> +  ASSERT (Node != NULL);
> +
> +  NewNode = fdt_path_offset (mDeviceTreeBase, "/chosen");
> +  if (NewNode < 0) {
> +    NewNode = fdt_add_subnode (mDeviceTreeBase, 0, "/chosen");
> +  }
> +
> +  if (NewNode < 0) {
> +    return EFI_OUT_OF_RESOURCES;
> +  }
> +
> +  *Node = NewNode;

Haha, this wasn't part of v1 :) I missed it then. But, it looks like
renaming the function did lead to "enlightenment" -- or maybe more
extensive testing did.

Either way:

Reviewed-by: Laszlo Ersek <[email protected]>

> +  return EFI_SUCCESS;
> +}


_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to