On 04/08/16 11:44, Ard Biesheuvel wrote: > Instead of relying on VirtFdtDxe to populate the GIC related PCDs, move > this handling to our implementation of ArmGicArchLib, and retrieve the > required DT info using the new FDT client protocol. > > This removes one of the reasons we need to load VirtFdtDxe first using > an 'A PRIORI' declaration in the platform FDF. > > As Laszlo kindly confirms: > > So, ultimately, the only user of this library instance is > "ArmPkg/Drivers/ArmGic/ArmGicDxe.inf". ... Indeed, checking the build > report file for ArmVirtQemu (AARCH64), I find ArmVirtGicArchLib (and > ArmGicLib too) only under "ArmPkg/Drivers/ArmGic/ArmGicDxe.inf". > > which means that the constructor is only invoked once, and so the dynamic > PCDs are set in time for ArmGicDxe to consume them, and never afterwards. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <[email protected]> > --- > ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c | 75 > ++++++++++++++++++-- > ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.inf | 18 +++-- > 2 files changed, 85 insertions(+), 8 deletions(-)
Nice! Reviewed-by: Laszlo Ersek <[email protected]> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
