On 04/21/16 08:58, Ruiyu Ni wrote:
> The patch changes PlatformBdsConnectSequence() to use library API
> exposed from UefiBootManagerLib and removes the additional
> connect ALL action.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu...@intel.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> ---
>  OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Please change the subject to:

  OvmfPkg/PlatformBootManagerLib: port PlatformBdsConnectSequence to 
UefiBootManagerLib

(It is 85 characters long, but we can't do anything about it -- the function 
and library names are just long.)

With that:

Reviewed-by: Laszlo Ersek <ler...@redhat.com>

Thanks!
Laszlo

> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c 
> b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> index 43a859c..dc6bc7f 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> @@ -1075,7 +1075,6 @@ PlatformBdsRestoreNvVarsFromHardDisk (
>  
>  }
>  
> -
>  VOID
>  PlatformBdsConnectSequence (
>    VOID
> @@ -1112,14 +1111,15 @@ Returns:
>      //
>      // Build the platform boot option
>      //
> -    BdsLibConnectDevicePath (gPlatformConnectSequence[Index]);
> +    EfiBootManagerConnectDevicePath (gPlatformConnectSequence[Index], NULL);
>      Index++;
>    }
>  
>    //
>    // Just use the simple policy to connect all devices
>    //
> -  BdsLibConnectAll ();
> +  DEBUG ((EFI_D_INFO, "EfiBootManagerConnectAll\n"));
> +  EfiBootManagerConnectAll ();
>  
>    PciAcpiInitialization ();
>  
> @@ -1338,9 +1338,6 @@ Routine Description:
>    // Process QEMU's -kernel command line option
>    //
>    TryRunningQemuKernel ();
> -
> -  DEBUG ((EFI_D_INFO, "BdsLibConnectAll\n"));
> -  BdsLibConnectAll ();
>    BdsLibEnumerateAllBootOption (BootOptionList);
>  
>    SetBootOrderFromQemu (BootOptionList);
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to