On 04/21/16 08:58, Ruiyu Ni wrote:
> EnableQuietBoot and DisableQuietBoot are copied from
> IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c.
> Because these two functions are not in UefiBootManagerLib.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu...@intel.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> ---
> .../Library/PlatformBootManagerLib/BdsPlatform.h | 33 +
> .../PlatformBootManagerLib.inf | 3 +
> OvmfPkg/Library/PlatformBootManagerLib/QuietBoot.c | 668
> +++++++++++++++++++++
> 3 files changed, 704 insertions(+)
> create mode 100644 OvmfPkg/Library/PlatformBootManagerLib/QuietBoot.c
Two remarks:
> + default:
> + //
> + // Other bit format BMP is not supported.
> + //
> + if (IsAllocated) {
> + FreePool (*GopBlt);
> + *GopBlt = NULL;
> + }
> + return EFI_UNSUPPORTED;
> + break;
This break statement is not present in the original (and it is dead code
here).
> + //
> + // Get the specified image from FV.
> + //
> + Status = GetSectionFromAnyFv (LogoFile, EFI_SECTION_RAW, 0, (VOID **)
> &ImageData, &ImageSize);
> + if (EFI_ERROR (Status)) {
> + return EFI_UNSUPPORTED;
> + }
> +
> + CoordinateX = 0;
> + CoordinateY = 0;
> + Attribute = EfiBadgingDisplayAttributeCenter;
This again differs from the original, where, dependent on
PcdBootlogoOnlyEnable, we set EfiBadgingDisplayAttributeCustomized instead.
Any reason for this difference?
The patch looks good otherwise (with the issues fixed that Gary brought up).
Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
