On 04/21/16 08:58, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu...@intel.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> ---
> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 11 -----------
> OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c | 12 +-----------
> 2 files changed, 1 insertion(+), 22 deletions(-)
One question:
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> index 4bde841..3d05999 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> @@ -68,7 +68,6 @@ Abstract:
> #include <OvmfPlatforms.h>
>
> extern EFI_DEVICE_PATH_PROTOCOL *gPlatformConnectSequence[];
> -extern EFI_DEVICE_PATH_PROTOCOL *gPlatformDriverOption[];
> extern ACPI_HID_DEVICE_PATH gPnpPs2KeyboardDeviceNode;
> extern ACPI_HID_DEVICE_PATH gPnp16550ComPortDeviceNode;
> extern UART_DEVICE_PATH gUartDeviceNode;
> @@ -221,16 +220,6 @@ PlatformBdsShowProgress (
> );
>
> VOID
> -PlatformBdsConnectSequence (
> - VOID
> - );
The definition for this function does exist -- why are you removing the
prototype?
Or else, is the idea that the prototype should be removed if there is no
external caller? I can agree with that as well, but in that case, a lot
more could be removed.
So, I'm not saying that this patch is wrong; I just find the selection
arbitrary. I think we should either not remove this prototype, or remove
a lot more (for example, all the Convert*() prototypes). What do you think?
Thanks!
Laszlo
> -
> -EFI_STATUS
> -ProcessCapsules (
> - EFI_BOOT_MODE BootMode
> - );
> -
> -VOID
> PlatformInitializeConsole (
> IN PLATFORM_CONSOLE_CONNECT_ENTRY *PlatformConsole
> );
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
> b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
> index 4f8cdf7..e9737a7 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
> @@ -2,7 +2,7 @@
> Defined the platform specific device path which will be used by
> platform Bbd to perform the platform policy connect.
>
> - Copyright (c) 2004 - 2008, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be
> found at
> @@ -15,11 +15,6 @@
>
> #include "BdsPlatform.h"
>
> -//
> -// Predefined platform default time out value
> -//
> -UINT16 gPlatformBootTimeOutDefault = 5;
> -
> ACPI_HID_DEVICE_PATH gPnpPs2KeyboardDeviceNode = gPnpPs2Keyboard;
> ACPI_HID_DEVICE_PATH gPnp16550ComPortDeviceNode = gPnp16550ComPort;
> UART_DEVICE_PATH gUartDeviceNode = gUart;
> @@ -40,11 +35,6 @@ PLATFORM_CONSOLE_CONNECT_ENTRY gPlatformConsole[] = {
> };
>
> //
> -// Predefined platform specific driver option
> -//
> -EFI_DEVICE_PATH_PROTOCOL *gPlatformDriverOption[] = { NULL };
> -
> -//
> // Predefined platform connect sequence
> //
> EFI_DEVICE_PATH_PROTOCOL *gPlatformConnectSequence[] = { NULL };
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
