Hi, Marcin Patch 2 could get my RB. Reviewed-by: Feng Tian <[email protected]>
I have comments on other patches. 1. Patch 1 is correct fix. But could you also help fix the problem in EmmcPeimSetBusMode(), which also pass down a wrong argument order to EmmcPeimSwitchToHighSpeed()? 2. Other patches are all related with PIO transfer. Could you let me know any backgrounds/details why the force PIO mode is needed? Thanks Feng -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Marcin Wojtas Sent: Tuesday, June 21, 2016 9:09 AM To: [email protected] Cc: [email protected]; [email protected]; [email protected]; Gao, Liming <[email protected]>; Kinney, Michael D <[email protected]> Subject: [edk2] [PATCH 0/6] MMC fixes and PIO mode Hello, Changes implemented in this patchset: * Add fixes for MMC devices Small fixes including adding proper delay, and reorder function parameters are implemented * Add PIO mode support There are adjustments necessary for SdBlockIo layer to perform data transfer in PIO mode. PcdSdForcePioMode flag is created in order to force using PIO instead of DMA. It is necessary to implement proper changes in PassThru protocol for making use of this feature. SdDxe driver wasn't modified due to lack of equipment for testing, however PIO mode proved to be successfully working with SDHCI driver (based heavily on SdDxe) in OpenPlatformPkg, which uses EDK2 generic SD/MMC stack. Any comments or remarks would be very welcome. Best regards, Marcin Wojtas Jan Dąbroś (4): MdeModulePkg/SdDxe: Add PcdSdForcePioMode MdeModulePkg/SdDxe: Add sending StopTransmission command MdeModulePkg/SdDxe: Add checking device status procedure MdeModulePkg/SdDxe: Add SetBlockLen command Joe Zhou (2): MdeModulePkg: Fix parameters order in EmmcSwitchToHighSpeed call MdeModulePkg: Add delay before eMMC reset MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 5 +- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 142 ++++++++++++++++++++++++ MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 3 + MdeModulePkg/Bus/Sd/SdDxe/SdDxe.h | 1 + MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf | 2 + MdePkg/MdePkg.dec | 7 ++ 6 files changed, 159 insertions(+), 1 deletion(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
