Thanks for your details, Jan. If we can find another way to avoid introducing a new interface, that is PCD, I would vote it. Your new solution makes more sense for me:-).
Best Regards Feng -----Original Message----- From: Jan Dąbroś [mailto:[email protected]] Sent: Tuesday, June 21, 2016 6:12 PM To: Tian, Feng <[email protected]> Cc: Marcin Wojtas <[email protected]>; [email protected]; [email protected]; Gao, Liming <[email protected]>; [email protected]; [email protected]; Kinney, Michael D <[email protected]> Subject: Re: [edk2] [PATCH 0/6] MMC fixes and PIO mode Hi Feng, > I have comments on other patches. > 1. Patch 1 is correct fix. But could you also help fix the problem in > EmmcPeimSetBusMode(), which also pass down a wrong argument order to > EmmcPeimSwitchToHighSpeed()? Ok, we will add this change also. > 2. Other patches are all related with PIO transfer. Could you let me know any > backgrounds/details why the force PIO mode is needed? We have problem with DMA modes in our controller, hence we have to use PIO mode. I think there is another way (if this isn't acceptable), to enable transfer in PIO. We could choose transfer mode according to capabilities register instead of using PCD flag. We will perform no-DMA transfers only if ADMA and SDMA bits are cleared. What do you think about this? Best Regards, Jan _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
