Hi Feng,

> I have comments on other patches.
> 1. Patch 1 is correct fix. But could you also help fix the problem in 
> EmmcPeimSetBusMode(), which also pass down a wrong argument order to 
> EmmcPeimSwitchToHighSpeed()?

Ok, we will add this change also.

> 2. Other patches are all related with PIO transfer. Could you let me know any 
> backgrounds/details why the force PIO mode is needed?

We have problem with DMA modes in our controller, hence we have to use
PIO mode. I think there is another way (if this isn't acceptable), to
enable transfer in PIO. We could choose transfer mode according to
capabilities register instead of using PCD flag. We will perform
no-DMA transfers only if ADMA and SDMA bits are cleared. What do you
think about this?

Best Regards,
Jan
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to