On 06/29/16 21:30, Olaf Hering wrote: > Adjust the code to look forward instead of backwards. > Existing gcc releases are known to work or break. Upcoming gcc releases > are assumed to work like the last handled gcc version does. > Doing it that way will reduce the burden to update the script for each > upcoming gcc variant. > > This fixes issue #99.
(I think Jordan prefers tags of the form Fixes: https://github.com/tianocore/edk2/issues/99 because they auto-close the github issues. This can be updated at commit time.) > > Signed-off-by: Olaf Hering <[email protected]> > --- > OvmfPkg/build.sh | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index eb5eb73..b40e561 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -83,6 +83,13 @@ case `uname` in > Linux*) > gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}') > case $gcc_version in > + 4.[3210].*|3.*|2.*) > + echo "gcc version $gcc_version is unsupported" > + exit 1 > + ;; > + 4.4.*) > + TARGET_TOOLS=GCC44 > + ;; > 4.5.*) > TARGET_TOOLS=GCC45 > ;; > @@ -99,7 +106,8 @@ case `uname` in > TARGET_TOOLS=GCC49 > ;; > *) > - TARGET_TOOLS=GCC44 > + # assume the latest, we cant keep up with gcc releases "can't" -- can be fixed up at commit time With those addressed (no need for a v2): Reviewed-by: Laszlo Ersek <[email protected]> I'll defer to Jordan on this, like I said in #99. Thanks! Laszlo > + TARGET_TOOLS=GCC49 > ;; > esac > esac > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
