On 2016-07-05 07:37:58, Laszlo Ersek wrote: > On 06/30/16 12:16, Laszlo Ersek wrote: > > On 06/30/16 07:00, Olaf Hering wrote: > >> On Wed, Jun 29, Jordan Justen wrote: > >> > >>> Missing Contributed-under. (See OvmfPkg/Contributions.txt) > >> > >> Looks like this project tries to avoid simple fixes from third party. > > > > It's not the case. Every project has its contribution rules (I reckon > > xen-devel is no exception). It takes some time to set everything up in > > order to contribute in accordance with the rules, but that's a one time > > cost for every contributor. > > > > If we encouraged drive-by patches without regard to the process, then it > > would be a constant cost for long term participants / maintainers. > > > > I do agree with you on two points -- I find these unjustified / > > gratuitous burdens: > > - the Contributed-under line > > - having to subscribe to the mailing list in order to post > > > > The first is alas a legal requirement, and I can't do anything about it. > > Luckily, it can be automated at least. See for example > > > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-07 > > > > The second (the subscription requirement) is terrible. No other open > > source project I'm aware of follows that requirement. I've raised it > > several times, but other subscribers on the list disagree with me. > > > >> I'm done with it. > > > > I'm sorry to hear that. I don't really see why you can't post a v2 of > > your patch, with all the remarks addressed, considering you will likely > > carry such a patch in your downstream anyway. I encourage you to send a v2. > > I guess you decided not to do it. :( > > Jordan: do you think I can pick up Olaf's patch and resubmit it with > your remarks addressed? I'm asking because the original patch did not > have the Contributed-under line, and I wonder if it's okay if I add: >
If Olaf is not willing or able to add Contributed-under for his patch, then I think we need to skip it. We can re-implement it pretty easily after a few weeks. Maybe we can just address the issue at the same time that we add support for clang and gcc6, when Steven Shi finishes those. -Jordan > Signed-off-by: Olaf Hering <[email protected]> > Fixes: https://github.com/tianocore/edk2/issues/99 > [[email protected]: update commit message] > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <[email protected]> > > I think we've seen such examples on the list recently (i.e., one author > writing the original patch internally at a company, without the > Contributed-under line, then another contributor picking it up and > posting it according to Contributions.txt, preserving the original > authorship too). I think it should work but I figured I'd ask you first. > > Thanks > Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
