On 2016-06-29 12:30:35, Olaf Hering wrote:
> Adjust the code to look forward instead of backwards.
> Existing gcc releases are known to work or break. Upcoming gcc releases
> are assumed to work like the last handled gcc version does.
> Doing it that way will reduce the burden to update the script for each
> upcoming gcc variant.
> 
> This fixes issue #99.

Fixes: https://github.com/tianocore/edk2/issues/99

> Signed-off-by: Olaf Hering <[email protected]>

Missing Contributed-under. (See OvmfPkg/Contributions.txt)

> ---
>  OvmfPkg/build.sh | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index eb5eb73..b40e561 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -83,6 +83,13 @@ case `uname` in
>    Linux*)
>      gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}')
>      case $gcc_version in
> +      4.[3210].*|3.*|2.*)
> +        echo "gcc version $gcc_version is unsupported"
> +        exit 1
> +        ;;
> +      4.4.*)
> +        TARGET_TOOLS=GCC44
> +        ;;
>        4.5.*)
>          TARGET_TOOLS=GCC45
>          ;;
> @@ -99,7 +106,8 @@ case `uname` in
>          TARGET_TOOLS=GCC49
>          ;;
>        *)
> -        TARGET_TOOLS=GCC44
> +        # assume the latest, we cant keep up with gcc releases

I think we should not add this comment.

-Jordan

> +        TARGET_TOOLS=GCC49
>          ;;
>      esac
>  esac
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to