Yes. I will make one patch to fix it. Thanks for your report. From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, June 30, 2016 1:40 AM To: Bruce Cran <br...@cran.org.uk>; Cinnamon Shia <cinnamon.s...@hpe.com>; edk2-de...@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com>; Gao, Liming <liming....@intel.com>; Zeng, Star <star.z...@intel.com> Subject: Re: [edk2] [PATCH v2] MdeModulePkg/MemoryStatusCode: Expose the DXE memory status code table.
On 06/29/16 16:47, Bruce Cran wrote: > On 6/27/2016 1:25 AM, Cinnamon Shia wrote: >> Let data of DXE memory status code can be used by other modules. >> 1. Save the address of DXE memory status code table to >> DxeConfigurationTable. >> 2. Save the address of SMM memory status code table to >> SmmConfigurationTable. >> 3. Move RUNTIME_MEMORY_STATUSCODE_HEADER to its public header file. > > I'm getting an error building OVMF today, which appears related: > > In file included from > /home/bcran/workspace/edk2/IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/SerialStatusCodeWorker.c:15:0: > > /home/bcran/workspace/edk2/IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.h:63:3: > error: conflicting types for 'RUNTIME_MEMORY_STATUSCODE_HEADER' > } RUNTIME_MEMORY_STATUSCODE_HEADER; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from > /home/bcran/workspace/edk2/IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.h:22:0, > > from > /home/bcran/workspace/edk2/IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/SerialStatusCodeWorker.c:15: > > /home/bcran/workspace/edk2/MdeModulePkg/Include/Guid/MemoryStatusCodeRecord.h:76:3: > note: previous declaration of 'RUNTIME_MEMORY_STATUSCODE_HEADER' was here > } RUNTIME_MEMORY_STATUSCODE_HEADER; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Yes, the file IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.h includes MdeModulePkg/Include/Guid/MemoryStatusCodeRecord.h but also defines the RUNTIME_MEMORY_STATUSCODE_HEADER type, which has now become redundant. As far as I can see, it should be fixable by removing the RUNTIME_MEMORY_STATUSCODE_HEADER typedef from "IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCodeRuntimeDxe.h". Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
