Laszlo: I have sent the patch to fix it. Besides, I suggest to update Ovmf DSC/FDF to use StatusCode Router and Handler from MdeModulePkg instead of IntelFrameworkModulePkg.
Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Gao, Liming > Sent: Thursday, June 30, 2016 9:02 AM > To: Laszlo Ersek <[email protected]>; Bruce Cran <[email protected]>; > Cinnamon Shia <[email protected]>; [email protected] > Cc: Tian, Feng <[email protected]>; Zeng, Star <[email protected]> > Subject: Re: [edk2] [PATCH v2] MdeModulePkg/MemoryStatusCode: Expose > the DXE memory status code table. > > Yes. I will make one patch to fix it. Thanks for your report. > > From: Laszlo Ersek [mailto:[email protected]] > Sent: Thursday, June 30, 2016 1:40 AM > To: Bruce Cran <[email protected]>; Cinnamon Shia > <[email protected]>; [email protected] > Cc: Tian, Feng <[email protected]>; Gao, Liming <[email protected]>; > Zeng, Star <[email protected]> > Subject: Re: [edk2] [PATCH v2] MdeModulePkg/MemoryStatusCode: Expose > the DXE memory status code table. > > On 06/29/16 16:47, Bruce Cran wrote: > > On 6/27/2016 1:25 AM, Cinnamon Shia wrote: > >> Let data of DXE memory status code can be used by other modules. > >> 1. Save the address of DXE memory status code table to > >> DxeConfigurationTable. > >> 2. Save the address of SMM memory status code table to > >> SmmConfigurationTable. > >> 3. Move RUNTIME_MEMORY_STATUSCODE_HEADER to its public header > file. > > > > I'm getting an error building OVMF today, which appears related: > > > > In file included from > > > /home/bcran/workspace/edk2/IntelFrameworkModulePkg/Universal/Statu > sCode/RuntimeDxe/SerialStatusCodeWorker.c:15:0: > > > > > /home/bcran/workspace/edk2/IntelFrameworkModulePkg/Universal/Statu > sCode/RuntimeDxe/StatusCodeRuntimeDxe.h:63:3: > > error: conflicting types for 'RUNTIME_MEMORY_STATUSCODE_HEADER' > > } RUNTIME_MEMORY_STATUSCODE_HEADER; > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from > > > /home/bcran/workspace/edk2/IntelFrameworkModulePkg/Universal/Statu > sCode/RuntimeDxe/StatusCodeRuntimeDxe.h:22:0, > > > > from > > > /home/bcran/workspace/edk2/IntelFrameworkModulePkg/Universal/Statu > sCode/RuntimeDxe/SerialStatusCodeWorker.c:15: > > > > > /home/bcran/workspace/edk2/MdeModulePkg/Include/Guid/MemoryStat > usCodeRecord.h:76:3: > > note: previous declaration of 'RUNTIME_MEMORY_STATUSCODE_HEADER' > was here > > } RUNTIME_MEMORY_STATUSCODE_HEADER; > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Yes, the file > > IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCode > RuntimeDxe.h > > includes > > MdeModulePkg/Include/Guid/MemoryStatusCodeRecord.h > > but also defines the RUNTIME_MEMORY_STATUSCODE_HEADER type, which > has > now become redundant. > > As far as I can see, it should be fixable by removing the > RUNTIME_MEMORY_STATUSCODE_HEADER typedef from > "IntelFrameworkModulePkg/Universal/StatusCode/RuntimeDxe/StatusCod > eRuntimeDxe.h". > > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
