Jordan, Thanks for the review.
I think the multiple license topic may need more discussion. Is the file organization you recommend documented somewhere? Do you have a link? If a project uses a git submodule, is the license from the submodule added to the parent project? For example, see OpenSSL email from earlier today: https://lists.01.org/pipermail/edk2-devel/2017-July/012471.html The edk2-non-osi repository is another example where we have license files next to the content to which the license applies. My goal is to update edk2 to use the same consistent style when multiple licenses are in use. I can drop the OvmfPkg changes for this series and we can continue this discussion and also wait to hear from Laszlo on this topic. Thanks, Mike > -----Original Message----- > From: Justen, Jordan L > Sent: Thursday, July 20, 2017 3:54 PM > To: Kinney, Michael D <[email protected]>; edk2- > [email protected]; Laszlo Ersek <[email protected]> > Cc: Leif Lindholm <[email protected]>; Andrew Fish > <[email protected]> > Subject: RE: [Patch V3 7/8] edk2: Move License.txt file to root > > On 2017-07-20 08:09:52, Kinney, Michael D wrote: > > Hi Jordan, > > > > Yes. The ECP change is on purpose to make ECP license > > consistent with the majority of the edk2 content. > > Nice. For some reason I thought we couldn't make this change > previously. > > You'll update the commit message to note the change? Yes > > > The summary of all licenses used in all components has > > been added to Readme.md in the root of the edk2 repo, > > so any developer that looks at this repo know all the > > licenses in use without having to search through all > > the directories in the repository. > > I disagree. I'd like to keep the OvmfPkg/License.txt file. I also > think that any other package that uses multiple licenses should > do the > same. > > If you drop "[Patch V3 6/8] edk2/OvmfPkg: Add MIT license files" > and > the OvmfPkg change in this patch, then: > > Reviewed-by: Jordan Justen <[email protected]> > > > > > > -----Original Message----- > > > From: Justen, Jordan L > > > Sent: Wednesday, July 19, 2017 11:36 PM > > > To: Kinney, Michael D <[email protected]>; edk2- > > > [email protected]; Laszlo Ersek <[email protected]> > > > Cc: Leif Lindholm <[email protected]>; Andrew Fish > > > <[email protected]> > > > Subject: Re: [Patch V3 7/8] edk2: Move License.txt file to > root > > > > > > On 2017-07-19 22:44:10, Michael D Kinney wrote: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=642 > > > > > > > > Add top level License.txt file with the BSD 2-Clause > > > > License that is used by the majority of the EKD II open > > > > source project content. Merge copyright statements > > > > from the BSD 2-Clause License files in each package > > > > directory and remove the duplication License.txt > > > > file from package directories. > > > > > > > > Cc: Leif Lindholm <[email protected]> > > > > Cc: Andrew Fish <[email protected]> > > > > Cc: Jordan Justen <[email protected]> > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Michael D Kinney > <[email protected]> > > > > --- > > > > AppPkg/License.txt | 25 -------------- > --- > > > > ArmPkg/License.txt | 26 -------------- > ---- > > > > ArmPlatformPkg/License.txt | 25 -------------- > --- > > > > BaseTools/License.txt | 25 -------------- > --- > > > > BeagleBoardPkg/License.txt | 26 -------------- > ---- > > > > CorebootModulePkg/License.txt | 25 -------------- > --- > > > > CorebootPayloadPkg/License.txt | 25 -------------- > --- > > > > CryptoPkg/License.txt | 25 -------------- > --- > > > > DuetPkg/License.txt | 25 -------------- > --- > > > > EdkCompatibilityPkg/License.txt | 29 -------------- > ---- > > > -- > > > > > > ECP currently has a 3-clause BSD license in License.txt. Is > this > > > change intended? I think that the ECP source file headers may > > > point to > > > the 2-clause BSD license though. > > > > > > Maybe worth noting in the commit message. > > > > > > > EdkShellBinPkg/License.txt | 25 -------------- > --- > > > > EdkShellPkg/License.txt | 25 -------------- > --- > > > > EmbeddedPkg/License.txt | 26 -------------- > ---- > > > > EmulatorPkg/License.txt | 25 -------------- > --- > > > > FatBinPkg/License.txt | 25 -------------- > --- > > > > FatPkg/License.txt | 25 -------------- > --- > > > > IntelFrameworkModulePkg/License.txt | 25 -------------- > --- > > > > IntelFrameworkPkg/License.txt | 25 -------------- > --- > > > > IntelFsp2Pkg/License.txt | 25 -------------- > --- > > > > IntelFsp2WrapperPkg/License.txt | 25 -------------- > --- > > > > IntelFspPkg/License.txt | 25 -------------- > --- > > > > IntelFspWrapperPkg/License.txt | 25 -------------- > --- > > > > IntelSiliconPkg/License.txt | 25 -------------- > --- > > > > ArmVirtPkg/License.txt => License.txt | 6 ++-- > > > > MdeModulePkg/License.txt | 25 -------------- > --- > > > > MdePkg/License.txt | 25 -------------- > --- > > > > NetworkPkg/License.txt | 25 -------------- > --- > > > > Nt32Pkg/License.txt | 25 -------------- > --- > > > > Omap35xxPkg/License.txt | 26 -------------- > ---- > > > > OptionRomPkg/License.txt | 25 -------------- > --- > > > > OvmfPkg/License.txt | 50 -------------- > ---- > > > ---------------- > > > > > > I'm not sure about Laszlo, but I prefer to keep the current > > > License.txt at the OvmfPkg root. It gives an 'overview' of > the > > > licenses used in the package without having to search the > > > sub-directories. > > > > > > -Jordan > > > > > > > PcAtChipsetPkg/License.txt | 25 -------------- > --- > > > > PerformancePkg/License.txt | 25 -------------- > --- > > > > QuarkPlatformPkg/License.txt | 25 -------------- > --- > > > > QuarkSocPkg/License.txt | 25 -------------- > --- > > > > SecurityPkg/License.txt | 25 -------------- > --- > > > > ShellBinPkg/License.txt | 25 -------------- > --- > > > > ShellPkg/License.txt | 25 -------------- > --- > > > > SignedCapsulePkg/License.txt | 25 -------------- > --- > > > > SourceLevelDebugPkg/License.txt | 25 -------------- > --- > > > > StdLib/License.txt | 25 -------------- > --- > > > > StdLibPrivateInternalFiles/License.txt | 25 -------------- > --- > > > > UefiCpuPkg/License.txt | 25 -------------- > --- > > > > Vlv2DeviceRefCodePkg/License.txt | 25 -------------- > --- > > > > Vlv2TbltDevicePkg/License.txt | 25 -------------- > --- _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
