On 07/21/17 01:39, Kinney, Michael D wrote: > Jordan, > > Thanks for the review. > > I think the multiple license topic may need more discussion. > Is the file organization you recommend documented somewhere? > Do you have a link? If a project uses a git submodule, is > the license from the submodule added to the parent project? > > For example, see OpenSSL email from earlier today: > > https://lists.01.org/pipermail/edk2-devel/2017-July/012471.html > > The edk2-non-osi repository is another example where we have > license files next to the content to which the license applies. > > My goal is to update edk2 to use the same consistent style when > multiple licenses are in use. > > I can drop the OvmfPkg changes for this series and we can continue > this discussion and also wait to hear from Laszlo on this topic.
Personally I would prefer the smallest amount of license files scattered around OvmfPkg specifically and the tree generally. What does QEMU do? http://git.qemu.org/?p=qemu.git;a=blob;f=LICENSE http://git.qemu.org/?p=qemu.git;a=blob;f=disas/libvixl/LICENCE http://git.qemu.org/?p=qemu.git;a=blob;f=tcg/LICENSE I guess the idea is that the project root license defines the default license, and lists all known exceptions by pathname pattern. Plus, those subdirs contain their own license files. Finally, all files come with a license banner (matching the most specific license file towards the project root). Git submodules are not taken into account in the project root license. I think this is too complex. I don't feel strongly about this either way, but my preference would be (again) the lowest number of license files one has to look at. So perhaps one root license file with a default license, and pathname patterns that cumulatively cover all of the exceptions. Or one license file per package, with a default license for the package, plus pathname patterns, where the patterns cumulatively cover all of the exceptions within the package. Hm... Looks like this is already what "OvmfPkg/License.txt" does? Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
