> -----Original Message-----
> From: Laszlo Ersek [mailto:[email protected]]
> Sent: Friday, October 05, 2018 4:33 AM
> To: Carsey, Jaben <[email protected]>; Andrew Fish
> <[email protected]>
> Cc: [email protected]
> Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment
> variable
> Importance: High
>
> On 10/04/18 22:54, Carsey, Jaben wrote:
> > Laszlo,
> >
> > The leading "_" was required for out of spec, but built in, commands. The
> spec has no restrictions on environment variables except some have special
> meaning and may be read only.
> >
> > I can certainly work on slowing down the process. I have been complaining
> about that same thing and should have been more aware. I would like to
> have a community minimum amount of time before commits are done that
> we all agree to. Something like 1 full day would be nice I think.
>
> Good idea! I believe 24 hours should be tolerable on all ends. It also
> gives a chance to people in other time zones to comment.
So how do we proceed? What's the "deciding method" to have a minimum time to
allow for reviews?
>
> I think there should be one exception: grave regressions -- build
> failures, or total boot failures -- should be possible to revert (or
> fix) as soon as there's one review.
Agreed. We need some way around when an error is made.
>
> Thanks!
> Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
