On 10/5/2018 8:19 PM, Tim Lewis wrote:
Jaben --
Following on this: shouldn't this be a spec issue? If you are asking people
to depend on the behavior.
I agree. So I suggest submit a Spec ECR for this change.
Since it was checked in, we can revert it if the ECR is rejected.
Thanks,
Tim
-----Original Message-----
From: edk2-devel <[email protected]> On Behalf Of Laszlo Ersek
Sent: Friday, October 5, 2018 4:33 AM
To: Carsey, Jaben <[email protected]>; Andrew Fish <[email protected]>
Cc: [email protected]
Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment
variable
On 10/04/18 22:54, Carsey, Jaben wrote:
Laszlo,
The leading "_" was required for out of spec, but built in, commands. The
spec has no restrictions on environment variables except some have special
meaning and may be read only.
I can certainly work on slowing down the process. I have been complaining
about that same thing and should have been more aware. I would like to have
a community minimum amount of time before commits are done that we all agree
to. Something like 1 full day would be nice I think.
Good idea! I believe 24 hours should be tolerable on all ends. It also gives
a chance to people in other time zones to comment.
I think there should be one exception: grave regressions -- build failures,
or total boot failures -- should be possible to revert (or
fix) as soon as there's one review.
Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
--
Thanks,
Ray
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
