On 10/23/2018 11:12 AM, Lohr, Paul A wrote:
Hello,
Code to remove SMRAM = UC (line 650-ish) looks good. I would suggest adding
some debug comments in the area it was removed. Thanks.
debug message or comments?
I guess you'd like to have some comments to say "SMRR is enabled by CPU
SMM driver so no need to reset the SMRAM to UC in MTRR". Correct?
Per #4, I also "think" the second SMRAM = UC should be removed, in addition to
the SMRAM = WB in the same area. But this is under investigation now. Expect an update
in 24-48 hours.
I did some search in close source platform code and found out that the
SMRAM is set to WB by default.
So it turns out setting SMRAM to WB is unnecessary here. But this
introduces a platform assumption. If platform doesn't set SMRAM to WB,
removing the WB set here will cause system boot performance downgrade.
Above is my understanding.
Please post update here once you finish the investigation.
Per #5, I too do not like the "CPU AP" comment, as I initially thought it
referred to Application Processor 😊 Yes, please clean that AP comment up!
Sure I will do that.
Paul A. Lohr – Server Firmware Enabling
512.239.9073 (cell)
512.794.5044 (work)
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
