Hello - update on this issue: 1) SMRAM = UC in SmmIplDxeDispatchEventNotify() around line 650 can be removed, yes. Code never modified anything, so there is nothing to "undo." 2) SMRAM = WB \ SMRAM = UC in SmmIplEntry() around lines 1600-1675 is still being considered.
Please separate these check-ins and begin checking in #1. We can continue the discussion on #2. Paul A. Lohr – Server Firmware Enabling 512.239.9073 (cell) 512.794.5044 (work) -----Original Message----- From: Laszlo Ersek <[email protected]> Sent: Tuesday, October 23, 2018 4:44 AM To: Ni, Ruiyu <[email protected]>; Lohr, Paul A <[email protected]>; [email protected] Cc: Kinney, Michael D <[email protected]>; Yao, Jiewen <[email protected]> Subject: Re: [edk2] [PATCH] MdeModulePkg/PiSmmIpl: Do not reset SMRAM to UC when CPU driver runs On 10/23/18 11:36, Ni, Ruiyu wrote: > On 10/23/2018 11:12 AM, Lohr, Paul A wrote: >> Hello, >> >> Code to remove SMRAM = UC (line 650-ish) looks good. I would suggest >> adding some debug comments in the area it was removed. Thanks. > > debug message or comments? > I guess you'd like to have some comments to say "SMRR is enabled by > CPU SMM driver so no need to reset the SMRAM to UC in MTRR". Correct? Such a comment sounds great to me, just please include: "by calling SmmCpuFeaturesInitializeProcessor from SmmCpuFeaturesLib". [...] Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
