On 10/23/18 11:36, Ni, Ruiyu wrote: > On 10/23/2018 11:12 AM, Lohr, Paul A wrote: >> Hello, >> >> Code to remove SMRAM = UC (line 650-ish) looks good. I would suggest >> adding some debug comments in the area it was removed. Thanks. > > debug message or comments? > I guess you'd like to have some comments to say "SMRR is enabled by CPU > SMM driver so no need to reset the SMRAM to UC in MTRR". Correct?
Such a comment sounds great to me, just please include: "by calling SmmCpuFeaturesInitializeProcessor from SmmCpuFeaturesLib". [...] Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
