Jordan, This is a clang warning.
There are coding styles (not the edk2 way) where folks do assignments as a side effect of the comparison in an if. If you follow this form, then the extra parentheses can mean you missed a = you had intended. Andrew Fish On Sep 21, 2012, at 10:12 AM, Jordan Justen wrote: > Which compiler & edk2 toolchain are you using? > > Maybe you can provide a patch? See MdeModulePkg/Contributions.txt. > > It'd be good to include the affected toolchain in your changelog text > if you provide a patch. > > -Jordan > > On Fri, Sep 21, 2012 at 9:20 AM, Sergey Isakov <[email protected]> wrote: >> Dear MdeModulePkg maintainers, >> Correct please the error >> -------------- >> /Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1458:47: >> error: equality comparison with extraneous parentheses >> [-Werror,-Wparentheses-equality] >> } else if ((InputString[*Index + StrOffset] == CHAR_LINEFEED)) { >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ >> /Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1458:47: >> note: remove extraneous parentheses around the comparison to silence this >> warning >> } else if ((InputString[*Index + StrOffset] == CHAR_LINEFEED)) { >> ~ ^ ~ >> /Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1458:47: >> note: use '=' to turn this equality comparison into an assignment >> } else if ((InputString[*Index + StrOffset] == CHAR_LINEFEED)) { >> ^~ >> = >> /Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1467:47: >> error: equality comparison with extraneous parentheses >> [-Werror,-Wparentheses-equality] >> } else if ((InputString[*Index + StrOffset] == CHAR_CARRIAGE_RETURN)) { >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ >> /Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1467:47: >> note: remove extraneous parentheses around the comparison to silence this >> warning >> } else if ((InputString[*Index + StrOffset] == CHAR_CARRIAGE_RETURN)) { >> ~ ^ ~ >> /Users/sergey/src/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c:1467:47: >> note: use '=' to turn this equality comparison into an assignment >> } else if ((InputString[*Index + StrOffset] == CHAR_CARRIAGE_RETURN)) { >> ^~ >> -------------- >> As far as I understand we just have to remove double braces. >> >> Sergey >> ------------------------------------------------------------------------------ >> Got visibility? >> Most devs has no idea what their production app looks like. >> Find out how fast your code is with AppDynamics Lite. >> http://ad.doubleclick.net/clk;262219671;13503038;y? >> http://info.appdynamics.com/FreeJavaPerformanceDownload.html >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > Got visibility? > Most devs has no idea what their production app looks like. > Find out how fast your code is with AppDynamics Lite. > http://ad.doubleclick.net/clk;262219671;13503038;y? > http://info.appdynamics.com/FreeJavaPerformanceDownload.html > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
