Got it, I will update the code to fix it. I think we can just update the
definition like below:
vfrFormSetDefinition ::=
"formset"
"guid" "=" guidDefinition ","
"title" "=" getStringId ","
"help" "=" getStringId
{"," "classguid" "=" classguidDefinition}
{"," "class" "=" classDefinition}
{"," "subclass" "=" subclassDefinition}
(
";"
|"," \\ compatible with old format
)
vfrFormSetList
"endformset" ";"
Thanks,
Eric
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, January 22, 2013 11:20 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] ";" rules for formset in VFR?
Eric -
It is "this definition does not follow the VFR code style?" Many other opcodes
have optional pieces, but end in ";" Only formset ends in a "," So I would like
to allow ";" also. I don't want to break existing code, just make VFR rules
easier to follow.
Tim
From: Dong, Eric
[mailto:eric.d...@intel.com]<mailto:[mailto:eric.d...@intel.com]>
Sent: Monday, January 21, 2013 7:16 PM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2] ";" rules for formset in VFR?
Tim,
VFR spec definition for formset opcode in the follow format:
vfrFormSetDefinition ::=
"formset"
"guid" "=" guidDefinition ","
"title" "=" getStringId ","
"help" "=" getStringId ","
{ "classguid" "=" classguidDefinition "," }
{ "class" "=" classDefinition "," }
{ "subclass" "=" subclassDefinition "," }
vfrFormSetList
"endformset" ";"
Because "classguid" "class" and "subclass" are all optional, we can't correctly
detect the end of the opcode and don't know which place we can put the ";".
We can update the definition to use ";" at the end. I just curious why your
raise this issue? Does this format not meet your special request? Or just found
this definition not follows VFR code style?
Thanks,
Eric
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Tuesday, January 22, 2013 2:40 AM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] ";" rules for formset in VFR?
Is there some specific reason why "vfrFormSetDefinition" does not have a ";"
after the "subclass" keyword? Instead it uses a comma. But "form" and every
other statement ends in a ";"
Tim
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
