Thanks your patch. I will evaluate it and feedback to you. Jeff
-----Original Message----- From: Konstantin Filatov [mailto:kfila...@parallels.com] Sent: Tuesday, January 22, 2013 4:15 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Make the upper memory usable. On 01/19/2013 08:29 AM, Isakov Sergey wrote: > On 17.01.2013, at 15:17, Konstantin Filatov wrote: > > >> Hello, >> >> >> --- CpuDxe/CpuDxe.c >> +++ CpuDxe/CpuDxe.c >> @@ -1110,13 +1110,9 @@ RestoreInterruptDescriptorTableHandlerAddress ( >> IN UINTN Index >> ) >> { >> - if (Index< mOrigIdtEntryCount) { >> - gIdtTable[Index].Bits.OffsetLow = >> mOrigIdtEntry[Index].Bits.OffsetLow; >> - gIdtTable[Index].Bits.OffsetHigh = >> mOrigIdtEntry[Index].Bits.OffsetHigh; >> -#if defined (MDE_CPU_X64) >> - gIdtTable[Index].Bits.OffsetUpper = >> mOrigIdtEntry[Index].Bits.OffsetUpper; >> -#endif >> > This is wrong. > You must not exclude #if defined... > because OffsetUpper is not defined for IA32 > > Sergey > > > ---------------------------------------------------------------------- > -------- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, > HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your > skills current with LearnDevNow - 3,200 step-by-step video tutorials > by Microsoft MVPs and experts. SALE $99.99 this month only -- learn > more at: > http://p.sf.net/sfu/learnmore_122912 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > This is correct :-) I changed this quoted noodle code to: CopyMem(gIdtTable + Index, mOrigIdtEntry + Index, sizeof(gIdtTable[Index])); where sizeof(struct IA32_IDT_GATE_DESCRIPTOR) depends on MDE_CPU_X64. So this CPU-versioning was taken in account properly. Konstantin Filatov P.S. I will send a patch to correct %ss-issue soon. ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
