On 04/28/13 02:28, Jordan Justen wrote: > On Tue, Apr 23, 2013 at 3:18 AM, Laszlo Ersek <[email protected]> wrote: >> @@ -199,13 +198,9 @@ VirtioPrepare ( >> >> In *Indices: >> >> - @param [in] HeadIdx The index identifying the head buffer (first >> - buffer appended) belonging to this same >> - request. >> - >> - @param [in out] NextAvailIdx On input, the index identifying the next >> - descriptor available to carry the buffer. On >> - output, incremented by one, modulo 2^16. >> + @param [in out] NextDescIdx On input, the index identifying the next >> + descriptor to carry the buffer. On output, >> + incremented by one, modulo 2^16. > > Can you use @param just with the actual parameters?
Should I just move the "@param [in out]" string from NextDescIdx to Indices, or should I also drop NextDescIdx completely? Also, may I follow up with a separate patch for this? To me it would seem a bit more logical to keep these changes separate, and (for some reason) it also feels safer. > Do you think an addition to OvmfPkg/README for Virtio usage would be useful? I don't know. People will (or will not) be aware how to configure virtio devices in qemu, independently of OVMF. What do you have in mind? Thanks Laszlo ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
