On 04/29/13 03:14, Laszlo Ersek wrote: > On 04/28/13 02:28, Jordan Justen wrote: >> On Tue, Apr 23, 2013 at 3:18 AM, Laszlo Ersek <[email protected]> wrote: >>> @@ -199,13 +198,9 @@ VirtioPrepare ( >>> >>> In *Indices: >>> >>> - @param [in] HeadIdx The index identifying the head buffer >>> (first >>> - buffer appended) belonging to this same >>> - request. >>> - >>> - @param [in out] NextAvailIdx On input, the index identifying the next >>> - descriptor available to carry the buffer. >>> On >>> - output, incremented by one, modulo 2^16. >>> + @param [in out] NextDescIdx On input, the index identifying the next >>> + descriptor to carry the buffer. On output, >>> + incremented by one, modulo 2^16. >> >> Can you use @param just with the actual parameters? > > Should I just move the "@param [in out]" string from NextDescIdx to > Indices, or should I also drop NextDescIdx completely? > > Also, may I follow up with a separate patch for this? To me it would > seem a bit more logical to keep these changes separate, and (for some > reason) it also feels safer. > >> Do you think an addition to OvmfPkg/README for Virtio usage would be useful? > > I don't know. People will (or will not) be aware how to configure virtio > devices in qemu, independently of OVMF. What do you have in mind?
Ping... this fix is important. Please tell me in direct terms what I must do; I'd like to see this committed. Thanks, Laszlo ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
