On Thu, May 23, 2013 at 7:50 PM, Gao, Liming <liming....@intel.com> wrote:
> The patch is good. Reviewed-by: Liming Gao <liming....@intel.com>
>
> Besides, I help commit this change into EDKII project at r14387.

Liming,

Why did you merge Gary's two changes into one? As Laszlo had suggested
to Gary, I think they were better as 2 separate patches. Also, you
missed the Contributed-under part...

-Jordan

> -----Original Message-----
> From: Gary Ching-Pang Lin [mailto:g...@suse.com]
> Sent: Wednesday, May 22, 2013 12:15 PM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH 0/2] Add missing status strings to BasePrintLib
>
> Some error status strings were not defined in the status strings array. The 
> following patches add the missing strings so that %r prints comprehensive 
> strings instead of obscure numbers.
>
> Gary Ching-Pang Lin (2):
>   EdkCompatibilityPkg/BasePrintLib: add missing status strings for %r
>   MdePkg/BasePrintLib: add missing status strings for %r
>
>  .../Library/EdkIIGlueLib/Library/BasePrintLib/PrintLib.c | 11 +++++++++--
>  MdePkg/Library/BasePrintLib/PrintLibInternal.c           | 16 
> +++++++++++++---
>  2 files changed, 22 insertions(+), 5 deletions(-)
>
> --
> 1.8.1.4

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to