Hi Liming, On Fri, May 24, 2013 at 02:50:19AM +0000, Gao, Liming wrote: > The patch is good. Reviewed-by: Liming Gao <liming....@intel.com> > > Besides, I help commit this change into EDKII project at r14387. > The patch wasn't applied correctly. The missing part:
- "Protocol Error" // RETURN_PROTOCOL_ERROR = 24 | MAX_BIT + "Protocol Error", // RETURN_PROTOCOL_ERROR = 24 | MAX_BIT The missing comma makes wrong status strings, e.g. "Security Violation" became "CRC Error". Could you help fixing this bug? Thanks, Gary Lin > Thanks > Liming > -----Original Message----- > From: Gary Ching-Pang Lin [mailto:g...@suse.com] > Sent: Wednesday, May 22, 2013 12:15 PM > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] [PATCH 0/2] Add missing status strings to BasePrintLib > > Some error status strings were not defined in the status strings array. The > following patches add the missing strings so that %r prints comprehensive > strings instead of obscure numbers. > > Gary Ching-Pang Lin (2): > EdkCompatibilityPkg/BasePrintLib: add missing status strings for %r > MdePkg/BasePrintLib: add missing status strings for %r > > .../Library/EdkIIGlueLib/Library/BasePrintLib/PrintLib.c | 11 +++++++++-- > MdePkg/Library/BasePrintLib/PrintLibInternal.c | 16 > +++++++++++++--- > 2 files changed, 22 insertions(+), 5 deletions(-) > > -- > 1.8.1.4 > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
